[PATCH] D32249: [PartialInl] Enhance partial inliner to handle more complex conditions

[Easwaran Raman via Phabricator via llvm-commits]

eraman added a comment.

I've a couple of trivial comments so far. Could you please generate a diff with a larger context?



================
Comment at: lib/Transforms/IPO/PartialInlining.cpp:40
 
+  // Returns the ReturnBlock and NonReturnBlock
+  std::tuple<BasicBlock *, BasicBlock *> findEntryBlocks(Function *F);
----------------
The comments doesn't convey what the function is doing.


================
Comment at: lib/Transforms/IPO/PartialInlining.cpp:47
+  // has the previous block in the vector as its single predecessor and
+  // all the blocks in the change have a common non return block
+  // as their successor. The last block in the chain also has the return
----------------
nit: change -> chain


================
Comment at: lib/Transforms/IPO/PartialInlining.cpp:50
+  // block as its successor.
+  std::vector<BasicBlock *> Entries_;
   InlineFunctionInfo IFI;
----------------
Why is this named Entries_ and not Entries?


https://reviews.llvm.org/D32249