[PATCH] D32190: Make sure to scan mmap'd memory regions for root pointers on OS X

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added inline comments.


================
Comment at: lib/lsan/lsan_common.cc:86
 
-struct RootRegion {
-  const void *begin;
-  uptr size;
-};
-
 InternalMmapVector<RootRegion> *root_regions;
 
----------------
Can this be `static` since we now have `GetRootRegions`?


================
Comment at: lib/lsan/lsan_common.cc:291
 
-static void ProcessRootRegion(Frontier *frontier, uptr root_begin,
-                              uptr root_end) {
-  MemoryMappingLayout proc_maps(/*cache_enabled*/true);
+void ScanRootRegion(Frontier *frontier, RootRegion const &root_region,
+                    uptr region_begin, uptr region_end, uptr prot) {
----------------
Can this be `const RootRegion &` instead?  The rest of compiler-rt seems to heavily prefer `const X &` rather than `X const &`.  Same below.


Repository:
  rL LLVM

https://reviews.llvm.org/D32190