[PATCH] D31946: [legalize-types] Make softening result use a single map for replacements.

[Chih-Hung Hsieh via Phabricator via llvm-commits]

chh added a comment.

Does the new patch work with my previous attached c.zip?
I don't see new changes related to CopyToReg.

Again I worry about the new changes to FABS, FCOPYSIGN, and SELECT.
Why do you need those changes, but not FNEG, Register, etc.?
Those op codes used to cause problems with Android x86_64 fp128 types.
That's why I have them and some other opcodes in the
CanSkipSoftenFloatOperand function.

Does the new test soft-fp-legal-in-HW-reg.ll catch any error?
It should have some CHECK tags to verify compiled output.
It should also be tested with the android x86_64 mode, like:

  RUN: llc < %s -O2 -mtriple=x86_64-linux-android -mattr=+mmx \
  RUN:     -enable-legalize-types-checking | FileCheck %s --check-prefix=MMX
  RUN: llc < %s -O2 -mtriple=x86_64-linux-gnu -mattr=+mmx \
  RUN:     -enable-legalize-types-checking | FileCheck %s --check-prefix=MMX

Please see other tests in fp128-*.ll.
Thanks.


https://reviews.llvm.org/D31946