[PATCH] D32236: PR32710: Disable using PMADDWD for unsigned short.

[Dehao Chen via Phabricator via llvm-commits]

danielcdh added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:34634
   ShrinkMode Mode;
-  if (!canReduceVMulWidth(MulOp.getNode(), DAG, Mode))
+  if (!canReduceVMulWidth(MulOp.getNode(), DAG, Mode) || Mode == MULU16)
     return SDValue();
----------------
craig.topper wrote:
> Should we check Mode == MULU16 first and save the call if it is?
We actually need to call canReduceVMulWidth first because it will set the Mode.


================
Comment at: test/CodeGen/X86/madd.ll:1
 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+sse2 | FileCheck %s --check-prefix=SSE2
 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2 | FileCheck %s --check-prefix=AVX2
----------------
craig.topper wrote:
> Can we you just run utils/update_llc_test_checks.py on this file as an NFC pre-commit? Then use the script on your new test case.
done in r300740. Thanks


https://reviews.llvm.org/D32236