[PATCH] D31947: [scudo] Android support groundwork

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 19 12:11:32 PDT 2017


cryptoad added a comment.

In https://reviews.llvm.org/D31947#730825, @dvyukov wrote:

> In https://reviews.llvm.org/D31947#730656, @cryptoad wrote:
>
> > @dvyukov would it be acceptable to get this patch out in its current form and use this as a base for the further improvement you suggested?
> >  Namely: improve contention, potential use of the tsan TLS slot, rework thread/global initialization.
>
>
> Is there a pressing need?
>  I think the main problem with this change is that it's very large. You can get both if you split it. For example:
>
> 1. Minor, unrelated changes/refactorings.
> 2. Preparation for Android support, but no actual Android code (only Linux as now).
> 3. Rework initialization (but again no Android code).
> 4. Actual Android support (will not need to touch any common code, just provide platform-specific parts).


Sounds good.


https://reviews.llvm.org/D31947





More information about the llvm-commits mailing list