[zorg] r300731 - [sanitizers] Switch to gold on sanitizer-x86_64-linux bot

[Evgenii Stepanov via llvm-commits]

LLD adds some potential flakiness, unless it's pinned to a fixed
revision. Also, gold is much more common in Linux distributions.

Bfd is even more common, but the buildbot machine has something weird
going on with ld.bfd + 32-bit sysroot where it generates broken ELFs
and we don't have time to look at it properly (and also don't care
about i686 strongly enough), so gold is the next best thing.

On Wed, Apr 19, 2017 at 11:44 AM, Vitaly Buka <vitalybuka at google.com> wrote:
> +Evgenii Stepanov
>
> On Wed, Apr 19, 2017 at 11:42 AM Davide Italiano <davide at freebsd.org> wrote:
>>
>> On Wed, Apr 19, 2017 at 11:26 AM, Vitaly Buka via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>> > Author: vitalybuka
>> > Date: Wed Apr 19 13:26:36 2017
>> > New Revision: 300731
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=300731&view=rev
>> > Log:
>> > [sanitizers] Switch to gold on sanitizer-x86_64-linux bot
>> >
>> > Modified:
>> >     zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_cmake.sh
>> >
>> > Modified: zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_cmake.sh
>> > URL:
>> > http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_cmake.sh?rev=300731&r1=300730&r2=300731&view=diff
>> >
>> > ==============================================================================
>> > --- zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_cmake.sh
>> > (original)
>> > +++ zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_cmake.sh Wed
>> > Apr 19 13:26:36 2017
>> > @@ -29,7 +29,7 @@ MAKE_JOBS=${MAX_MAKE_JOBS:-16}
>> >  LLVM_CHECKOUT=$ROOT/llvm
>> >  ZLIB=$ROOT/zlib
>> >  COMPILER_RT_CHECKOUT=$LLVM_CHECKOUT/projects/compiler-rt
>> > -CMAKE_COMMON_OPTIONS="-DLLVM_ENABLE_ASSERTIONS=ON
>> > -DLLVM_PARALLEL_LINK_JOBS=10"
>> > +CMAKE_COMMON_OPTIONS="-DLLVM_USE_LINKER=gold
>> > -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_PARALLEL_LINK_JOBS=10"
>> >  ENABLE_LIBCXX_FLAG=
>> >  if [ "$PLATFORM" == "Darwin" ]; then
>> >    CMAKE_COMMON_OPTIONS="${CMAKE_COMMON_OPTIONS}
>> > -DPYTHON_EXECUTABLE=/usr/bin/python"
>> >
>>
>> Have you considered lld?
>>
>> Thanks,
>>
>> --
>> Davide
>>
>> "There are no solved problems; there are only problems that are more
>> or less solved" -- Henri Poincare