[PATCH] D32236: PR32710: Disable using PMADDWD for unsigned short.

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 19 11:58:04 PDT 2017


andreadb added a comment.

Hi Dehao (and Michael),

Test madd.ll has wrong CHECK-LABEL comments. For example, I see that "label" checks are lower-case. Those should be all upper-case.
I think that those checks are never used in practice.

To avoid problems with FileCheck, I also suggest to add an explicit check line for the 'ret' statement. That way, we know exactly what is the range of instructions where (v)pmaddwd should not appear.

-Andrea


https://reviews.llvm.org/D32236





More information about the llvm-commits mailing list