[PATCH] D32021: CodeGen: Let frame index value type match alloca addr space

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.

LGTM with test cleanups



================
Comment at: test/CodeGen/AMDGPU/frame-index-amdgiz.ll:14
+
+define amdgpu_kernel void @f(i32 addrspace(1)* nocapture %a, i32 %i, i32 %j) local_unnamed_addr #0 !kernel_arg_addr_space !2 !kernel_arg_access_qual !3 !kernel_arg_type !4 !kernel_arg_base_type !4 !kernel_arg_type_qual !5 {
+entry:
----------------
Drop metadata


================
Comment at: test/CodeGen/AMDGPU/frame-index-amdgiz.ll:54
+
+attributes #0 = { nounwind "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="false" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-features"="+fp64-fp16-denormals,-fp32-denormals" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { argmemonly nounwind }
----------------
Strip unnecessary string attributes


================
Comment at: test/CodeGen/AMDGPU/frame-index-amdgiz.ll:58
+
+!opencl.ocl.version = !{!0}
+
----------------
You can drop this


https://reviews.llvm.org/D32021