[lld] r300445 - [ELF] - Add compress-debug-output-i386.s testcase.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 19 04:29:01 PDT 2017


?> Please revert this file. The -compress-debug-section flag is not an architecture-dependent feature. One test is enough.

But compressed section header is different for 32/64 bit. In current code without the test, else branch is uncovered:

  if (Config->Is64) {
    Buf += sizeof(Elf64_Word); // Skip ch_reserved field.
    write64<E>(Buf, Size);
    Buf += sizeof(ELFT::Chdr::ch_size);
    write64<E>(Buf, Alignment);
    Buf += sizeof(ELFT::Chdr::ch_addralign);
  } else {
    write32<E>(Buf, Size);
    Buf += sizeof(ELFT::Chdr::ch_size);
    write32<E>(Buf, Alignment);
    Buf += sizeof(ELFT::Chdr::ch_addralign);
  }?

George.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170419/6c2e96e8/attachment.html>


More information about the llvm-commits mailing list