[PATCH] D32053: Define __tls_get_addr as a hidden symbol even for ARM or MIPS.

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 19 03:13:35 PDT 2017


peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.

I agree that the code is now redundant and can be removed. It used to be the case that addIgnored() would define the symbol even when there was an existing definition and cause a duplicate error. It looks like this was later fixed in -r287125 Don't error if __tls_get_addr is defined.

Apologies for the delay in responding, I've just come back from Easter break.


https://reviews.llvm.org/D32053





More information about the llvm-commits mailing list