[PATCH] D29942: Add custom lowering for llvm.log{, 10}.{f16, f32} intrinsics

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with minor test cleanup



================
Comment at: test/CodeGen/AMDGPU/llvm.log10.ll:2
+; RUN: llc < %s -march=amdgcn | FileCheck %s --check-prefix=SI --check-prefix=FUNC
+; RUN: llc < %s -march=amdgcn -mcpu=tonga | FileCheck %s --check-prefix=SI --check-prefix=FUNC
+; RUN: llc < %s -march=r600 -mcpu=redwood | FileCheck %s --check-prefix=EG --check-prefix=FUNC
----------------
s/SI/GCN


================
Comment at: test/CodeGen/AMDGPU/llvm.log10.ll:18
+entry:
+   %0 = call float @llvm.log10.f32(float %in)
+   store float %0, float addrspace(1)* %out
----------------
Can you name these vars?


https://reviews.llvm.org/D29942