[PATCH] D32202: [XRay][compiler-rt] Fix up CFI annotations and stack alignment

Martin Pelikán via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 22:35:30 PDT 2017


pelikan accepted this revision.
pelikan added a comment.
This revision is now accepted and ready to land.

While it's obvious to me this won't hurt, I'm not convinced the compiler can freely expect the stack to be 16-byte aligned because it doesn't know before link-time what other objects will go into the resulting binary (and corrupt this assumption).  The amd64 ABI only requires 8-byte alignments.


https://reviews.llvm.org/D32202





More information about the llvm-commits mailing list