[PATCH] D32211: Collapse AArch64/Utils into AArch64/MCTargetDesc

Richard Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 19:15:23 PDT 2017


rsmith created this revision.
Herald added subscribers: mgorny, rengolin, aemerson.

Fix a layering violation (cyclic dependency) between AArch64/Utils and AArch64/MCTargetDesc by folding the single header and source file form the former into the latter. Every user of the Utils file already depends on and includes parts of MCTargetDesc, and there is no clear layering between these two.


Repository:
  rL LLVM

https://reviews.llvm.org/D32211

Files:
  lib/Target/AArch64/AArch64.h
  lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp
  lib/Target/AArch64/AArch64FastISel.cpp
  lib/Target/AArch64/AArch64ISelLowering.cpp
  lib/Target/AArch64/AArch64InstrInfo.cpp
  lib/Target/AArch64/AArch64MCInstLower.cpp
  lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
  lib/Target/AArch64/AsmParser/LLVMBuild.txt
  lib/Target/AArch64/CMakeLists.txt
  lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp
  lib/Target/AArch64/Disassembler/AArch64ExternalSymbolizer.cpp
  lib/Target/AArch64/Disassembler/LLVMBuild.txt
  lib/Target/AArch64/InstPrinter/AArch64InstPrinter.cpp
  lib/Target/AArch64/InstPrinter/LLVMBuild.txt
  lib/Target/AArch64/LLVMBuild.txt
  lib/Target/AArch64/MCTargetDesc/AArch64BaseInfo.cpp
  lib/Target/AArch64/MCTargetDesc/AArch64BaseInfo.h
  lib/Target/AArch64/MCTargetDesc/AArch64MCCodeEmitter.cpp
  lib/Target/AArch64/MCTargetDesc/CMakeLists.txt
  lib/Target/AArch64/Utils/AArch64BaseInfo.cpp
  lib/Target/AArch64/Utils/AArch64BaseInfo.h
  lib/Target/AArch64/Utils/CMakeLists.txt
  lib/Target/AArch64/Utils/LLVMBuild.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32211.95678.patch
Type: text/x-patch
Size: 53091 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170419/c708f4dc/attachment.bin>


More information about the llvm-commits mailing list