[PATCH] D32206: X86RegisterInfo: eliminateFrameIndex: Avoid code duplication; NFC

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 18:18:21 PDT 2017


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lib/Target/X86/X86RegisterInfo.cpp:676
+  unsigned BasePtr;
+  if (MI.isReturn()) {
+    FIOffset = TFI->getFrameIndexReferenceSP(MF, FrameIndex, BasePtr, 0);
----------------
I guess conditional tail calls don't have memory operands. You can't conditionally jump to the pointer in a memory location.


Repository:
  rL LLVM

https://reviews.llvm.org/D32206





More information about the llvm-commits mailing list