[PATCH] D32202: [XRay][compiler-rt] Fix up CFI annotations and stack alignment

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 17:10:48 PDT 2017


dberris created this revision.

Previously, we had been very undisciplined about CFI annotations with
the XRay trampolines. This leads to runtime crashes due to mis-alined
stack pointers that some function implementations may run into (i.e.
those using instructions that require properly aligned addresses coming
from the stack). This patch attempts to clean that up, as well as more
accurately use the correct amounts of space on the stack for stashing
and un-stashing registers.


https://reviews.llvm.org/D32202

Files:
  lib/xray/xray_trampoline_x86_64.S

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32202.95658.patch
Type: text/x-patch
Size: 3207 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170419/196e9d7e/attachment.bin>


More information about the llvm-commits mailing list