[PATCH] D32194: Turn symbolication on for ASan unit test.

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl created this revision.
Herald added subscribers: kubamracek, rengolin, aemerson.

On PowerPC and ARM (possibly, need to verify), couple tests involving
pthread_exit fail due to leaks detected by LSan. pthread_exit tries
to perform unwinding that leads to dlopen'ing libgcc_s.so. dlopen
mallocs "libgcc_s.so" string which confuses LSan, it fails to
realize that this allocation happens in dynamic linker and should
be ignored.
Symbolized leak report is required to define a suppression for this
known problem.


https://reviews.llvm.org/D32194

Files:
  lib/asan/tests/asan_test_main.cc


Index: lib/asan/tests/asan_test_main.cc
===================================================================
--- lib/asan/tests/asan_test_main.cc
+++ lib/asan/tests/asan_test_main.cc
@@ -13,16 +13,15 @@
 #include "asan_test_utils.h"
 #include "sanitizer_common/sanitizer_platform.h"
 
-// Default ASAN_OPTIONS for the unit tests. Let's turn symbolication off to
-// speed up testing (unit tests don't use it anyway).
+// Default ASAN_OPTIONS for the unit tests.
 extern "C" const char* __asan_default_options() {
 #if SANITIZER_MAC
   // On Darwin, we default to `abort_on_error=1`, which would make tests run
   // much slower. Let's override this and run lit tests with 'abort_on_error=0'.
   // Also, make sure we do not overwhelm the syslog while testing.
-  return "symbolize=false:abort_on_error=0:log_to_syslog=0";
+  return "abort_on_error=0:log_to_syslog=0";
 #else
-  return "symbolize=false";
+  return "";
 #endif
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32194.95637.patch
Type: text/x-patch
Size: 930 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170418/b78f17e6/attachment.bin>