[PATCH] D32102: Keep EXTRACT_VECTOR_ELT result type as f128 for Android x86_64.

[Chih-Hung Hsieh via Phabricator via llvm-commits]

chh added inline comments.


================
Comment at: test/CodeGen/X86/fp128-extract.ll:12
+define hidden fp128 @TestExtract() local_unnamed_addr align 2 {
+entry:
+  ; Simplified instruction pattern from the output of llvm before r289042,
----------------
niravd wrote:
> pirama wrote:
> > I also think the simplified version of the test below is preferable because it's easier to understand why the test fails without this fix.
> > 
> > ```
> > define fp128 @foo(<2 x double> %x) {
> >     %a = fpext <2 x double> %x to <2 x fp128>
> >     %1 = extractelement <2 x fp128> %a, i32 0
> >     %2 = extractelement <2 x fp128> %a, i32 1
> >     %3 = fmul fp128 %1, %2
> >     ret fp128 %3
> > }
> > ```
> > 
> > If you want to test this extended pattern from boost, consider adding both?
> > 
> > 
> Is TestExtract representive of pr32330 ? If so you should name it as such. 
This test case is extremely simplified to contain only the extractelement operation,
which I believe is the only opcode missed.
With this change, we can now compile pr32330 test case and found no regression with Android source.



https://reviews.llvm.org/D32102