[PATCH] D31947: [scudo] Android support groundwork

Stephen Hines via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 11:38:17 PDT 2017


srhines added a comment.

In https://reviews.llvm.org/D31947#728975, @rengolin wrote:

> In https://reviews.llvm.org/D31947#728503, @cryptoad wrote:
>
> > To be more specific, thread_local is supported via emutls (llvm/projects/compiler-rt/lib/builtins/emutls.c), which itself calls malloc to allocate the TLS.
> >  Which unfortunately doesn't work well for an allocator that replaces malloc.
>
>
> I thought we had fixed this one by asking the Android devs to implement proper TLS on Android. They said it was simple and wasn't there because no one needed it.
>
> @srhines, were you at the meeting with @jasonk, @kcc and some Android devs at Google, maybe 2 years ago? We discussed how `emutls` could be completely avoided.


It's unfortunately been too long. There was no progress there IIRC, so we didn't continue pursuing anything related to it. The bionic folks were also concerned about the direction that most of the patches were taking. Yabin added TSan support, but it isn't widely used in Android (it remains harder to set up than ASan).

> Or maybe I remember it wrong...
> 
> --renato




https://reviews.llvm.org/D31947





More information about the llvm-commits mailing list