[PATCH] D32165: Implement suspended thread register count for darwin

[Francis Ricci via Phabricator via llvm-commits]

fjricci added a comment.

In https://reviews.llvm.org/D32165#729513, @kubamracek wrote:

> Can we also get an implementation of GetRegistersAndSP?  It's hard to see where this patch is heading without the implementation of GetRegistersAndSP.
>
> But if there's something blocking GetRegistersAndSP, then this looks okay to me.


Uploaded the GetRegisters patch here - https://reviews.llvm.org/D32182



================
Comment at: lib/sanitizer_common/sanitizer_stoptheworld_mac.cc:16-17
 
 #if SANITIZER_MAC && (defined(__x86_64__) || defined(__aarch64__) || \
                       defined(__mips64) || defined(__i386))
 
----------------
kubamracek wrote:
> Btw, do we still need __mips64 here?  Darwin certainly doesn' support MIPS...
I'll put up a patch to get rid of that, not sure why it was added


https://reviews.llvm.org/D32165