[PATCH] D32118: Cleanup some GraphTraits iteration code
Alexander Kornienko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 18 05:21:15 PDT 2017
alexfh added a comment.
In https://reviews.llvm.org/D32118#729059, @alexfh wrote:
> In https://reviews.llvm.org/D32118#728077, @timshen wrote:
>
> > LGTM for GraphTraits-related changes (thought I also see an interface change on Split, which I know nothing about).
>
>
> I suppose, this change needs at least to be mentioned in the patch description along with a short explanation of why it is a no-op (I hope, it is? ;).
(full disclosure: I also don't know anything about Split, neither about the rest of the code here, and was reviewing mostly for coding style and overall sanity of the change.)
https://reviews.llvm.org/D32118
More information about the llvm-commits
mailing list