[PATCH] D31812: [ARM] Add hardware build attributes in assembler

[Oliver Stannard via Phabricator via llvm-commits]

olista01 added inline comments.


================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:71
+static cl::opt<bool> AddBuildAttributes("arm-add-build-attributes",
+                                        cl::init(false));
+
----------------
rengolin wrote:
> Why is this false? Don't we always want to emit the attributes?
We do want to emit attributes here when assembling an assembly file, but not when parsing inline assembly, so there's no obvious default when using this as part of clang. It's also not important what the default is when driving this from clang, as it doesn't change the final user interface.

When using this as a development/testing tool through llvm-mc, not emitting the build attributes is a sensible default, as you generally don't care about them, so I set this to default to false.


Repository:
  rL LLVM

https://reviews.llvm.org/D31812