[PATCH] D32120: Don't test setting sticky bits on files for (Free|Open)BSD

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Thanks for looking at this!



================
Comment at: unittests/Support/Path.cpp:1539
   EXPECT_TRUE(CheckPermissions(fs::all_perms));
+#endif // !FreeBSD && !OpenBSD
 #endif
----------------
Could you add an additional test that uses fs::all_perms, but without the sticky bit, please, so that we don't lose coverage of that enum value on FreeBSD? It wouldn't need to be inside the #if block. Something like the below:

```
  EXPECT_EQ(fs::setPermissions(TempPath, fs::all_perms & ~fs::sticky_bit), NoError);
  EXPECT_TRUE(CheckPermissions(fs::all_perms & ~fs::sticky_bit));
```


https://reviews.llvm.org/D32120