[PATCH] D21723: [RFC] Enhance synchscope representation

[Tony Tye via Phabricator via llvm-commits]

t-tye added inline comments.


================
Comment at: lib/AsmParser/LLLexer.cpp:548
   KEYWORD(singlethread);
+  KEYWORD(syncscope);
+  KEYWORD(amdgpu_agent);
----------------
Since there are now tokens for each syncscope value it seems it would be better to eliminate the "syncscope(ss)" syntax and just use the "ss" token in the same way "singlethread" and call convention abi tokens are used.


https://reviews.llvm.org/D21723