[PATCH] D32021: CodeGen: Let frame index value type match alloca addr space

[Yaxun Liu via Phabricator via llvm-commits]

yaxunl marked 3 inline comments as done.
yaxunl added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1829
   int FrameIdx = MFI.CreateStackObject(ByteSize, StackAlign, false);
-  return getFrameIndex(FrameIdx, TLI->getPointerTy(getDataLayout()));
+  return getFrameIndex(FrameIdx, TLI->getPointerTy(getDataLayout(),
+      getDataLayout().getAllocaAddrSpace()));
----------------
arsenm wrote:
> arsenm wrote:
> > Add a new TLI->getAllocaPointerTy?
> getFrameIndexTy would be better
will do.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5418
   }
   case Intrinsic::stackprotector: {
     // Emit code into the DAG to store the stack guard onto the stack.
----------------
arsenm wrote:
> This one hasn't been updated with mangling yet, so might as well leave it for now
will do.


https://reviews.llvm.org/D32021