[PATCH] D31524: Add a linker script to version LLVM symbols

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

> Note that we deliberately *don't* make LLVM_5.0 depend on LLVM_5.0:

Can you elaborate on what you mean by this? Do you mean LLVM_5.0 doesn't depend on LLVM_4.0?



================
Comment at: cmake/modules/AddLLVM.cmake:85
     add_custom_command(OUTPUT ${native_export_file}
-      COMMAND echo "{" > ${native_export_file}
+      COMMAND echo "LLVM_${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR} {" > ${native_export_file}
       COMMAND grep -q "[[:alnum:]]" ${export_file} && echo "  global:" >> ${native_export_file} || :
----------------
sylvestre.ledru wrote:
> rnk wrote:
> > Is this correct for DSOs that aren't libLLVM.so.N.M? This function is called from LLDB and elsewhere.
> It doesn't have too. libLLVM.so.N.M is for the SONAME.
> However, I can rename it, no worries
So, this doesn't refer to LLVM the DSO, it refers to LLVM the project. After this change, libclang.so will have symbols with LLVM_N.M as their version, right?


Repository:
  rL LLVM

https://reviews.llvm.org/D31524