[PATCH] D31922: Object: Use offset+size as the irsymtab string representation.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 17 10:30:57 PDT 2017


tejohnson added a comment.

It isn't clear to me why this is needed now but wasn't before. Was it the case that before the names were assumed to be null-terminated, and they will no longer be?



================
Comment at: llvm/lib/Object/IRSymtab.cpp:33
 
-  StringTableBuilder StrtabBuilder{StringTableBuilder::ELF};
+  StringTableBuilder StrtabBuilder{StringTableBuilder::RAW};
 
----------------
How does this change related to the rest of the patch?


https://reviews.llvm.org/D31922





More information about the llvm-commits mailing list