[PATCH] D31474: Update suspended threads info to be compatible with darwin

[Francis Ricci via Phabricator via llvm-commits]

fjricci added a comment.

In https://reviews.llvm.org/D31474#728236, @alekseyshl wrote:

> Yes, CHECK(0 && "not implemented") makes much more sense to the reader than dummy tid struct, it means exactly what it looks like, the functionality is not implemented.


It turns out that even the CHECK() isn't necessary for compilation on windows (I checked that asan+windows builds with this patch). Presumably if someone attempts to actually use stoptheworld on Windows, they'll hit a build error from the abstract class being unimplemented. I think this is exactly what we'd want (and even better than a CHECK).


https://reviews.llvm.org/D31474