[PATCH] D32048: ClamAV: Copy zlib into ClamAV benchmark

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

In https://reviews.llvm.org/D32048#727043, @kristof.beyls wrote:

> If a non-trivial amount of time is spent in zlib for clamav and we would want to retain benchmarking of the zlib library, maybe it'd be better to add zlib (with appropriate test input) as a separate benchmark to the test-suite?


There is already spec2000/164.gzip which has pretty much the same inflation/deflation code as zlib. Also this patch is not about adding a new benchmark but simply getting rid of an external dependency!

> We have modified other programs in the test-suite before to make them more useful for compiler performance evaluation and tracking, so I think that doing this would not go beyond what we've done before.
>  My guess is that performance tracking would be slightly easier if zlib was tested separately.

This isn't a good benchmark either way with the current inputs (~800k, of which ~210k are gzip compressed and hence zlib):

  $ llvm-lit MultiSource/Applications/ClamAV/clamscan.test
  ...
  exec_time: 0.0897

we should probably remove it from the `BENCHMARKING_ONLY` set (but in another patch).

With this only being a useful correctness/compile time test today, I'd vote to stay with the copying zlib solution as that is easier to do and is less invasive to the sourcecode.


Repository:
  rL LLVM

https://reviews.llvm.org/D32048