[PATCH] D32056: AMDGPU: Move trap lowering to DAG

[Tony Tye via Phabricator via llvm-commits]

t-tye added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:2404
+                                     Op.getDebugLoc(),
+                                     DS_Warning);
+    LLVMContext &Ctx = MF.getFunction()->getContext();
----------------
arsenm wrote:
> kzhuravl wrote:
> > Can we make it an error?
> We decided this should be a warning before, this isn't changing that
If there is no trap handler (namely it is not amdhsa) then the code generated is simply ignoring the llvm.debugtrap. So in this case is it better to give a warning or an error? If the llvm.debugtrap was present for a reason then ignoring it without giving an error may not be very helpful.


https://reviews.llvm.org/D32056