[PATCH] D30879: Distinguish between code pointer size and DataLayout::getPointerSize() in DWARF info generation

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: test/DebugInfo/AMDGPU/code-pointer-size.ll:1
+; RUN: llc -O0 -mtriple=amdgcn--amdhsa -mcpu=fiji -verify-machineinstrs -filetype=obj < %s | llvm-dwarfdump -debug-dump=info - | FileCheck %s
+
----------------
mehdi_amini wrote:
> Are all these parameters useful?
> why are you using `-verify-machineinstrs`?
-verify-machineinstrs can be omitted since we are checking dwarf. Thanks.


================
Comment at: test/DebugInfo/AMDGPU/variable-locations.ll:31
 ; CHECK-NEXT: DW_AT_decl_line
-; CHECK-NEXT: DW_AT_location [DW_FORM_block1] (<0x05> 03 00 00 00 00 )
 @GlobB = common addrspace(1) global i32 0, align 4, !dbg !6
----------------
mehdi_amini wrote:
> These were buggy before?
Yes.


https://reviews.llvm.org/D30879