[PATCH] D32090: [InstrProf] Fix Windows cross compilation TODOs to fix failing tests

[David Li via Phabricator via llvm-commits]

davidxl added a comment.

Can you extract the getObjectFormat Triple interface into a separate patch?

vsk has a bigger cleanup plan (to expose sectionKind) for more interface unification.  Perhaps we can wait for that patch (after getObjectFormat patch is in)?



================
Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp:655
+  if (ObjFormat == Triple::MachO)
+    ObjFormat = Triple::UnknownObjectFormat;
+  auto NamesSection =
----------------
Using 'unknown object' kind seems like a hack.  What vsk had in mind is to restore addsegment parameter but with default to false.


https://reviews.llvm.org/D32090