[PATCH] D32044: Don't read non-readable address ranges during lsan pointer scanning

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl requested changes to this revision.
alekseyshl added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/sanitizer_common/sanitizer_linux_libcdep.cc:449
       uptr cur_end = cur_beg + phdr->p_memsz;
       bool executable = phdr->p_flags & PF_X;
+      cur_module.addAddressRange(cur_beg, cur_end, executable,
----------------
bool readable = phdr->p_flags & PF_R; and use it later


================
Comment at: lib/sanitizer_common/sanitizer_procmaps_common.cc:145
+    cur_module.addAddressRange(cur_beg, cur_end, prot & kProtectionExecute,
+                               prot);
     modules->push_back(cur_module);
----------------
Maybe "prot & kProtectionRead"?


================
Comment at: lib/sanitizer_common/sanitizer_procmaps_mac.cc:266
+    cur_module->addAddressRange(cur_beg, cur_end, prot & kProtectionExecute,
+                                prot);
   }
----------------
Maybe "prot & kProtectionRead"?


https://reviews.llvm.org/D32044