[PATCH] D31474: Update suspended threads info to be compatible with darwin

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl added a comment.

Sorry for the push back, but the sanitizer_stoptheworld_win.h makes things really ugly. Now it feels like the entire SuspendedThreadsList implementation need to go into *_linux and *_mac specific files, leaving only the interface in sanitizer_stoptheworld.h:

class SuspendedThreadsList {
public:

  virtual uptr GetThreadCount() const = 0;
  virtual SuspendedThreadID GetThreadID(uptr index) const = 0;
  virtual uptr RegisterCount() = 0;
  virtual PtraceRegistersStatus GetRegistersAndSP(uptr index, uptr *buffer, uptr *sp) const = 0;

};

The actual implementation SuspendedThreadsListLinux/Mac is free to store whatever it needs. Does it look cleaner?


https://reviews.llvm.org/D31474