[PATCH] D32071: [CMake][libunwind] Fix the -target and -gcc-toolchain flag handling
Saleem Abdulrasool via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 14 10:00:27 PDT 2017
compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
================
Comment at: CMakeLists.txt:190
add_target_flags_if(LIBUNWIND_TARGET_TRIPLE
- "-target ${LIBUNWIND_TARGET_TRIPLE}")
+ "--target=${LIBUNWIND_TARGET_TRIPLE}")
add_target_flags_if(LIBUNWIND_GCC_TOOLCHAIN
----------------
I think that the space is easily worked with. We just need to append two items instead of one so that the quoting is handled properly. I do really prefer the single dash version for the `-target` flag.
Repository:
rL LLVM
https://reviews.llvm.org/D32071
More information about the llvm-commits
mailing list