[PATCH] D32023: [ProfileData] Support coverage for PE binaries

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 14 09:43:38 PDT 2017


rnk added inline comments.


================
Comment at: llvm/trunk/include/llvm/ProfileData/InstrProfData.inc:666
+
+#ifdef _WIN32
 /* Runtime section names and name strings.  */
----------------
This ifdef breaks cross compiling. In particular, llvm/test/Instrumentation/InstrProfiling/X86/alloc.ll is failing on Windows since this change. LLVM should choose the section name at runtime based on the target triple, not the host defines.


Repository:
  rL LLVM

https://reviews.llvm.org/D32023





More information about the llvm-commits mailing list