[PATCH] D32021: CodeGen: Let frame index value type match alloca addr space

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 14 09:41:27 PDT 2017


arsenm added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1829
   int FrameIdx = MFI.CreateStackObject(ByteSize, StackAlign, false);
-  return getFrameIndex(FrameIdx, TLI->getPointerTy(getDataLayout()));
+  return getFrameIndex(FrameIdx, TLI->getPointerTy(getDataLayout(),
+      getDataLayout().getAllocaAddrSpace()));
----------------
arsenm wrote:
> Add a new TLI->getAllocaPointerTy?
getFrameIndexTy would be better


https://reviews.llvm.org/D32021





More information about the llvm-commits mailing list