[PATCH] D32082: [ELF] - Implemented --defsym option

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 14 09:29:19 PDT 2017


ruiu added a comment.

This doesn't look good as you changed too many places for this little feature. Do you really have to support expressions that contain operators? I think you can start with supporting an assignments that consist of only two symbols in the form of -defsym=<sym1>=<sym2>.


https://reviews.llvm.org/D32082





More information about the llvm-commits mailing list