[PATCH] D32017: [MVT][SVE] Scalable vector MVTs (1/3)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 14 05:54:42 PDT 2017


RKSimon added a reviewer: RKSimon.
RKSimon added inline comments.


================
Comment at: include/llvm/CodeGen/ValueTypes.h:311
+      EVT EltVT = getVectorElementType();
+      EltVT = EVT::getIntegerVT(Context, EltVT.getSizeInBits() / 2);
+      return EVT::getVectorVT(Context, EltVT, getVectorNumElements());
----------------
assert that the size is even? Also, we don't seem to have a use for this function yet?


================
Comment at: include/llvm/CodeGen/ValueTypes.h:329
+      EVT EltVT = getVectorElementType();
+      auto EltCnt = getVectorNumElements();
+      return EVT::getVectorVT(Context, EltVT, EltCnt / 2);
----------------
Use unsigned for clarity and assert that its even? The asserts in LegalizeVectorTypes.cpp and SelectionDAG.cpp can then be dropped


https://reviews.llvm.org/D32017





More information about the llvm-commits mailing list