[PATCH] D32015: Make globalaa-retained.ll test catching more cases.

Andrei Elovikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 14 02:59:03 PDT 2017


a.elovikov added a comment.

In https://reviews.llvm.org/D32015#727116, @kristof.beyls wrote:

> In https://reviews.llvm.org/D32015#727113, @a.elovikov wrote:
>
> > I have to note that after http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20170410/444886.html
> >  [llvm] r300200 - Re-apply "[GVNHoist] Move GVNHoist to function simplification part of pipeline."
> >  that test starts failing.
>
>
> Does this mean that the test (if it had already been committed), would have found that r300200 breaks retaining GlobalsAA info; or is something wrong with the test?
>  Should GVNHoist be marked as preserving GlobalsAA? Or does it break GlobalsAA?


Yes, it would have found that. GVNHoist does not mark GlobalsAA as preserved. It most probably should but I'm not totally sure about that.


https://reviews.llvm.org/D32015





More information about the llvm-commits mailing list