[PATCH] D32016: [ELF] - Linkerscript: make section with no content to be SHT_PROGBITS by default.

[George Rimar via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL300317: [ELF] - Linkerscript: make section with no content to be SHT_PROGBITS by… (authored by grimar).

Changed prior to commit:
  https://reviews.llvm.org/D32016?vs=95125&id=95283#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D32016

Files:
  lld/trunk/ELF/LinkerScript.cpp
  lld/trunk/test/ELF/linkerscript/orphan-first-cmd.s
  lld/trunk/test/ELF/linkerscript/symbol-only.s


Index: lld/trunk/test/ELF/linkerscript/symbol-only.s
===================================================================
--- lld/trunk/test/ELF/linkerscript/symbol-only.s
+++ lld/trunk/test/ELF/linkerscript/symbol-only.s
@@ -12,7 +12,7 @@
 # CHECK:      Sections:
 # CHECK-NEXT: Idx Name          Size      Address
 # CHECK-NEXT:   0               00000000 0000000000000000
-# CHECK:          abc           00000000 [[ADDR:[0-9a-f]*]] BSS
+# CHECK:          abc           00000000 [[ADDR:[0-9a-f]*]] DATA
 # CHECK-NEXT:     bar           00000000 0000000000001000 DATA
 
 # CHECK: SYMBOL TABLE:
Index: lld/trunk/test/ELF/linkerscript/orphan-first-cmd.s
===================================================================
--- lld/trunk/test/ELF/linkerscript/orphan-first-cmd.s
+++ lld/trunk/test/ELF/linkerscript/orphan-first-cmd.s
@@ -4,7 +4,7 @@
 # RUN:         foo = 123; \
 # RUN:         . = 0x1000; \
 # RUN:         . = 0x2000; \
-# RUN:         .bar : { . = . + 1; } \
+# RUN:         .bar : { *(.bar) } \
 # RUN:       }" > %t.script
 # RUN: ld.lld -o %t -T %t.script %t.o -shared
 # RUN: llvm-readobj -s %t | FileCheck %s
@@ -16,3 +16,5 @@
 # CHECK-NEXT:   SHF_EXECINSTR
 # CHECK-NEXT: ]
 # CHECK-NEXT: Address: 0x1000
+
+.section .bar, "aw"
Index: lld/trunk/ELF/LinkerScript.cpp
===================================================================
--- lld/trunk/ELF/LinkerScript.cpp
+++ lld/trunk/ELF/LinkerScript.cpp
@@ -632,7 +632,7 @@
   // '.' is assigned to, but creating these section should not have any bad
   // consequeces and gives us a section to put the symbol in.
   uint64_t Flags = SHF_ALLOC;
-  uint32_t Type = SHT_NOBITS;
+  uint32_t Type = SHT_PROGBITS;
   for (BaseCommand *Base : Opt.Commands) {
     auto *Cmd = dyn_cast<OutputSectionCommand>(Base);
     if (!Cmd)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32016.95283.patch
Type: text/x-patch
Size: 1796 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170414/fd1a8b84/attachment.bin>