[PATCH] D32073: [ProfileData] Support cross target binary reading for coverage tool

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

I'm not aware of what the test failures are, but if they are affecting CI I'd prefer to revert everything temporarily.

As it stands this patch looks functionally OK, but I'm concerned about having overloads of the get*SectionName functions that do vs. do not include segment prefixes. I.e it's confusing to me that getInstrProfCoverageSectionName(/*isCoff*/false) and getInstrProfCoverageSectionName(MachOModule) return different results.

Wdyt of removing all of the get*SectionName helpers, and just exposing: getInstrProfSectionName(InstrProfSectKind IPSK, ObjectFileKind OFK, bool AddSegmentPrefix). It will make client code more verbose but very clear / unambiguous.


https://reviews.llvm.org/D32073