[PATCH] D32037: Change the testcase tail-merge-after-mbp.ll to tail-merge-after-mbp.mir

Wei Mi via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 13:15:54 PDT 2017


On Thu, Apr 13, 2017 at 11:41 AM, Geoff Berry via Phabricator
<reviews at reviews.llvm.org> wrote:
> gberry added a reviewer: MatzeB.
> gberry added a comment.
>
> I believe a lot of the IR in this test case is superfluous (as well as some of the MIR property flags like hasStackMap, etc.).  Could you try cutting it down to only the necessary IR and MIR to make it more robust against future changes?
> I've added Matthias as a reviewer since he is more familiar with the current state of the MIR parser.
>

The MIR test is generated directly based on the original .ll test. I
don't know well enough about the origial .ll test and whether it can
be easily simplified. Haicheng, do you have any idea about it?

To provide more background to MatzeB, the original test is from:
https://reviews.llvm.org/D23191

>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D32037
>
>
>


More information about the llvm-commits mailing list