[PATCH] D32005: [ARM] Check for correct HW div when lowering divmod

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 08:01:26 PDT 2017


compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

Minor comments on the test, but LGTM otherwise.



================
Comment at: test/CodeGen/ARM/divmod-hwdiv.ll:7
+
+; The hwdiv-arm subtarget feature should only influence arm, not thumb.
+; RUN: llc < %s -mtriple=arm-gnueabi -mattr=+hwdiv-arm | FileCheck %s -check-prefixes=ALL,ARM-HWDIV
----------------
I'm not sure I understand what the duplication here is for.  The compilation mode is identical to the ones above.  We should remove these I believe.


https://reviews.llvm.org/D32005





More information about the llvm-commits mailing list