[PATCH] D31902: Use correct registers for "A" inline asm constraint

[Ahmed Bougacha via Phabricator via llvm-commits]

ab accepted this revision.
ab added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

16-bit is weird, but it'd be great if you could add a testcase for that.



================
Comment at: test/CodeGen/X86/inline-asm-A-constraint.ll:1
+; RUN: llc < %s -march=x86-64 -no-integrated-as
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
----------------
'-march=x86_64' -> '-mtriple=x86_64--' ?  Helps avoid sensitivity to the host (not that it matters in this file) and lets you get rid of the IR triple.

Also, '-no-integrated-as' doesn't have an effect here, right?


================
Comment at: test/CodeGen/X86/inline-asm-A-constraint.ll:9
+entry:
+  %0 = call i128 asm "", "=A,~{dirflag},~{fpsr},~{flags}"()
+  store i128 %0, i128* @x, align 16
----------------
Can you add CHECK lines for the generated asm?


https://reviews.llvm.org/D31902