[PATCH] D31807: Fix signed multiplication with overflow fallback.

Ahmed Bougacha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 01:19:21 PDT 2017


ab accepted this revision.
ab added a comment.
This revision is now accepted and ready to land.

Nice catch, LGTM.

Looks like this should already be exercised by test/CodeGen/ARM/umulo-32.ll;  I'd say remove that file entirely.



================
Comment at: test/CodeGen/ARM/v6m-smul-with-overflow.ll:3
+
+define i1 @signed_multiplication_did_overflow(i32, i32) unnamed_addr {
+; CHECK-LABEL: signed_multiplication_did_overflow:
----------------
Remove 'unnamed_addr' ?


https://reviews.llvm.org/D31807





More information about the llvm-commits mailing list