[PATCH] D31981: Fix compiler error in Attributes.cpp

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 15:57:56 PDT 2017


kzhuravl added a comment.

In https://reviews.llvm.org/D31981#725043, @rnk wrote:

> Which platform exhibits this error? Also, it's an error, not a warning. The -Wreturn-type warning is a follow-on warning caused by the error in the return statement. Is this a problem with current or past versions libc++?
>
> FWIW, I lifted this make_pair usage from elsewhere, hoping it would be portable:
>
>   std::pair<unsigned, Optional<unsigned>>
>   AttributeSetNode::getAllocSizeArgs() const {
>     // ...
>     return std::make_pair(0, 0);
>   }
>


Thanks. g++-4.8.2 with libcxx at r264579 on Ubuntu 14.04 or 16.04.


https://reviews.llvm.org/D31981





More information about the llvm-commits mailing list