[PATCH] D31983: Free zone name when destroying malloc zone

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 15:08:10 PDT 2017


alekseyshl added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_malloc_mac.inc:62
   }
+  if (zone->zone_name) {
+    COMMON_MALLOC_FREE((void *)zone->zone_name);
----------------
fjricci wrote:
> alekseyshl wrote:
> > Nit: prefer no brackets for one liners
> Even for macros?
Ha, you're right, COMMON_MALLOC_FREE is . I was assuming multiline macro supposed to do this "do {} while (0)" trick. Anyway, ignore this nit.


https://reviews.llvm.org/D31983





More information about the llvm-commits mailing list