[PATCH] D31970: [libcxx] Direct support for Fuchsia

[Eric Fiselier via Phabricator via llvm-commits]

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM minus inline comments.



================
Comment at: include/__locale:44
 # include <support/musl/xlocale.h>
 #endif // __GLIBC__ || __APPLE__ || __FreeBSD__ || __sun__ || __EMSCRIPTEN__ || __IBMCPP__
 
----------------
This `#endif` comment is no longer correct. Please remove it as part of this change.


================
Comment at: include/support/fuchsia/xlocale.h:14
+
+#if defined(__Fuchsia__)
+
----------------
I don't see the need for this guard, since the header should never be included outside of a Fuchsia environment.
If anything it should read:

```
#if !defined(__Fuchsia__)
#error Fuchsia specific header incorrectly included
#endif
```


Repository:
  rL LLVM

https://reviews.llvm.org/D31970