[Diffusion] rL300015: [WebAssembly] Update use of Attributes after r299875

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 13:26:58 PDT 2017


dschuff added a comment.

This seems simpler, although it does expose a bit more the oddness of the way the function return, and argument attributes are all just glommed together in a list in some arbitrary order (at least I find it a little odd). Although fixing the naming and clarifying the documentation helps a lot.
I think practically speaking if there are almost always going to be attribute sets in all the positions, it makes sense just to have placeholders (empty attribute sets) instead of gaps in the list.


Users:
  dschuff (Author)

https://reviews.llvm.org/rL300015





More information about the llvm-commits mailing list