[PATCH] D29631: SystemZTargetTransformInfo cost functions and some common code changes

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

In https://reviews.llvm.org/D29631#724779, @jonpa wrote:

> Sorry - one test update unfortunately didn't go in at the first attempt, but it's fixed now.


Still isn't:

http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/6066

http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15/builds/6059

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/5372

The errors are like:

; CHECK: Cost Model: Found an estimated cost of 2 for instruction: %res11 = and <4 x i64> undef, undef

  ^

<stdin>:13:1: note: scanning from here
Cost Model: Found an estimated cost of 1 for instruction: %res11 = and <4 x i64> undef, undef

All of them. This should have been caught in your testing and I'm not sure why it hasn't. This breaks both 32 and 64 bits ARM.

Let's revert the patch and I can help you understand the problem once the bots are green.

cheers,
--renato


https://reviews.llvm.org/D29631